This repository was archived by the owner on Sep 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 146
Interface handling: generate queries for interface types + FRAGMENT_TYPE fix #336
Merged
+388
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce-types Support for Interface type queries
…ce-types prepublish -> prepare
Add inherited interfaces name as labels to nodes
…h for the right derived type label
Replaced FRAGMENT_TYPE value from first label found to properly searc…
Merge latest from upstream
Hey @flazoon! Thanks so much for this PR! Would you mind pulling in the latest commits from master? Looks like we had a slight conflict with another PR. But otherwise, this looks good to go! |
Merge latest from upstream
Thanks @johnymontana for the heads up, I've merged latest and fixed the conflicts. |
This looks awesome @flazoon, thank you so much for your work on this! I'm sorry about the timing with PRs here - I hope the conflicts aren't too much of a hassle 🎉 |
My pleasure to contribute @michaeldgraham. Always glad to see refactoring changes. |
Perfect. Thanks @flazoon! |
This was referenced Nov 7, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes addresses the following items:
e.g.
interface Person {
userId: ID!
name: String
}
type User implements Person {
userId: ID!
name: String
rated: [Rated]
}
type Query {
Person(
userId: ID
name: String
_id: String
first: Int
offset: Int
orderBy: [_PersonOrdering]
filter: _PersonFilter
): [Person]
User(
userId: ID
name: String
_id: String
first: Int
offset: Int
orderBy: [_UserOrdering]
filter: _UserFilter
): [User]
}
The fix follows the solution suggested here: Filter out labels with underscores. #301 (comment)