This repository was archived by the owner on Sep 3, 2021. It is now read-only.
Fixes for generated schema type and default config #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augmentOperationType now serves as a separate entry point for the augmentation of any operation type, Query, etc., Various helpers used for getting or setting values in a given schema type definition have also been added
schemaTypeDefinition is now returned from mapDefinitions, and the inline default configuration is removed
MutationB is changed back to Mutation to hit the logic that also handles checking for the existance of a default generated Mutation operation type, when completing fields on a schema type
Tests that a default of true still gets used when a configuration object is provided, rather than mistakenly requiring the user to explicitly set query, mutation, etc., to true
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 96.46% 96.51% +0.04%
==========================================
Files 24 24
Lines 2606 2643 +37
==========================================
+ Hits 2514 2551 +37
Misses 92 92
Continue to review full report at Codecov.
|
johnymontana
approved these changes
Nov 6, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #337 and #338 and contains some refactoring of how operation types (Query, Mutation, etc.) get handled in the augmentation process.