Skip to content
This repository was archived by the owner on Sep 3, 2021. It is now read-only.

Fix nested fragments on relations #385

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Fix nested fragments on relations #385

merged 2 commits into from
Feb 3, 2020

Conversation

ChristiaanScheermeijer
Copy link
Contributor

This pull request will fix nested fragments on relations combined with properties.

The following query resulted in an error:

fragment moreProperties on Camera {
  type
}

fragment properties on CameraMan {
  cameras {
    id
    ...moreProperties
  }
}

query {
  CameraMan {
    ...properties
  }
}

Caused by #377

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          24       24           
  Lines        2856     2856           
=======================================
  Hits         2754     2754           
  Misses        102      102
Impacted Files Coverage Δ
src/selections.js 97.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac28cfc...495eab4. Read the comment docs.

@johnymontana
Copy link
Contributor

Great - thanks @ChristiaanScheermeijer for the quick fix

@johnymontana johnymontana merged commit cec6b90 into neo4j-graphql:master Feb 3, 2020
@ChristiaanScheermeijer ChristiaanScheermeijer deleted the fix-nested-fragments-on-relations branch February 3, 2020 14:22
@ChristiaanScheermeijer
Copy link
Contributor Author

Glad I can help :-)

This issue is probably also suffering from the same bug: #384

@malikalimoekhamedov
Copy link

Definitely solves my issue.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants