This repository was archived by the owner on Sep 3, 2021. It is now read-only.
Fix for issue #446 #469
Merged
Fix for issue #446 #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes decideRelationTypeDirection as a result of refactoring the decision it was making when filtering the incoming direction of a relationship type. It had an undefined input argument for such cases, so a comparison was failing to ever result in swapping the variables for .from / .to nodes and reversing the relationship direction. This is done due to the use of a more static template once these variables get used to produce Cypher. Also removes a few unused function arguments
Issue #446 occured when filtering incoming relationships through a relationship type. This case was not tested in the TCK. Only outgoing cases were tested when querying from Person to Company, filtering over the `Person.employmentHistory` field. So a new test has been added that covers the reverse, querying from Company to Person, filtering over the `Company.employeeHistory` field.
johnymontana
approved these changes
Jul 8, 2020
steezeburger
added a commit
to Maya-PBC/neo4j-graphql-js
that referenced
this pull request
Jul 10, 2020
* upstream/master: 2.14.4 update changelog npm audit fix Don't use string for relationship direction in relation directive Fix for issue neo4j-graphql#446 (neo4j-graphql#469) 2.14.3 update changelog Fixes neo4j-graphql#465: Temporal and spatial identity filters (neo4j-graphql#466) Fix for relationship types using federated entities (neo4j-graphql#441) Add 4.1 to integration tests Add initial support for bookmarks Add integration tests for Neo4j v4.0.3 version Test with latest Neo4j and APOC Test with latest Neo4j v4.x and APOC versions
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an initial fix for issue #446