Bug-fix 4831

[MacondoExpress]

Description

This PR fix bug report #4831 was caused by an empty string and false boolean argument being evaluated as NULL when passed as an argument of a @cypher field.

Complexity

Complexity: Low

Issue

Closes #4831

Checklist

The following requirements should have been met (depending on the changes in the branch):

• Documentation has been updated
• TCK tests have been updated
• Integration tests have been updated
• Example applications have been updated
• New files have copyright header
• CLA (https://neo4j.com/developer/cla/) has been signed

[changeset-bot]

🦋 Changeset detected

Latest commit: 05a34ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@neo4j/graphql	Patch
@neo4j/graphql-toolbox	Patch
@neo4j/graphql-ogm	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[neo4j-team-graphql]

Thanks for the Neo4j GraphQL Toolbox updates.

The Neo4j GraphQL Toolbox has now been torn down - reopening this PR will republish it.

[neo4j-team-graphql]

Performance Report

No Performance Changes

Show Full Table

name	dbHits	old dbHits	time (ms)	old time (ms)	maxRows
aggregations.TopLevelAggregate	3404	3404	36	45	1134
aggregations.TopLevelAggregateWithMultipleFields	6802	6802	42	55	1134
aggregations.NestedAggregation	16544	16544	73	77	2174
aggregations.AggregationWithWhere	11970	11970	40	52	2174
aggregations.AggregationWhereWithinNestedRelationships	22116478	22116478	2091	2265	2008534
aggregations.AggregationWhereWithinNestedConnections	22116478	22116478	2164	2137	2008534
aggregations.NestedCountFromMovieToActors	9701	9701	30	38	2174
aggregations.NestedCountFromActorsToMovie	9928	9928	36	36	2174
aggregations.DeeplyNestedCount	11062184	11062184	2964	3158	2008534
aggregations.InterfacesAggregations	6242	6242	41	61	2080
aggregations.InterfacesAggregationsWithTwoFields	11444	11444	73	99	2080
batch-create.BatchCreate	4200	4200	123	169	600
batch-create.BatchCreateSmall	77	77	96	64	11
connect.createAndConnect	14424	14424	176	196	3003
connections.Connection	14049	14049	103	66	2174
connections.NestedConnection	41068	41068	154	140	4516
create.SimpleMutation	7	7	52	69	1
cypher-directive.TopLevelMutationDirective	1135	1135	32	25	1134
delete.SimpleDelete	19401	19401	256	202	1040
delete.NestedDeleteInUpdate	19165	19165	211	218	1999
2871.NestedRelationshipFilter	23161	23081	56	65	4458
2925.SingleRelationshipFilter	6468	6468	39	43	1040
2925.NestedSingleRelationshipFilter	22891	22891	78	105	2174
2925.SingleRelationshipRequiredFilter	5201	5201	34	40	1040
2925.NestedSingleRelationshipRequiredFilter	9361	9361	50	62	1040
query.SimpleQuery	3121	3121	20	22	1040
query.SimpleQueryWithRelationship	16129	16129	39	39	2174
query.QueryWhere	9677	9683	30	37	2162
query.SimpleQueryWithNestedWhere	9844	9850	45	53	2162
query.Nested	10095502	10095502	6944	7226	2008534
query.NestedWithFilter	10074351	10074351	6724	6756	2004000
query.OrFilterOnRelationships	41724	42263	133	164	1373
query.OrFilterOnRelationshipsAndNested	34997	35733	185	275	1373
query.QueryWithNestedIn	13672	13324	47	65	1317
query.NestedConnectionWhere	9801	9801	50	69	2174
query.DeeplyNestedConnectionWhere	10026	9860	68	86	2174
query.DeeplyNestedWithRelationshipFilters	18980	18800	116	155	1658
query.NestedWithRelationshipSingleFilters	3865	3865	136	167	1134
query.Fulltext	64	64	27	33	16
query.FulltextWithNestedQuery	558	558	37	46	84
sorting-and-cypher.TopLevelSortWithCypher	14059	14059	59	44	2174
sorting-and-cypher.TopLevelConnectionSortWithCypher	14059	14059	58	62	2174
sorting-and-cypher.TopLevelSortWithCypherWithNested	14204	14204	54	63	2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested	14204	14204	105	109	2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher	14848	14883	91	120	2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher	14404	14404	99	142	2174
sorting.SortMultipleTypes	3498	3498	84	89	1040
sorting.SortMultipleTypesWithCypherWithCypher	14504	14504	95	120	2174
sorting.SortOnNestedFields	14049	14049	41	51	2174
sorting.SortDeeplyNestedFields	43148	43148	72	89	4516
sorting.ConnectionWithSort	3281	3281	66	98	1040
unions.SimpleUnionQuery	321	321	53	78	35
unions.SimpleUnionQueryWithMissingFields	293	293	51	85	35
unions.NestedUnion	410637	410637	245	265	33033
unions.NestedUnionWithMissingFields	384611	384611	225	250	33033
update.NestedUpdate	16143	16143	100	130	2002

Old Schema Generation: 27.528s
Schema Generation: 25.773s
Old Subgraph Schema Generation: 31.501s
Subgraph Schema Generation: 29.915s