Construct routing driver from first available address #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technige
changed the title
lutovich
approved these changes
May 18, 2017
| * @param authToken authentication to use, see {@link AuthTokens} | ||
| * @return a new driver instance | ||
| */ | ||
| public static Driver routingDriverFromFirstAvailableAddress( List<String> addresses, AuthToken authToken ) |
There was a problem hiding this comment.
Maybe it is ok to not add this method because we do not add another overload with just list of addresses?
There was a problem hiding this comment.
I would also vote for a single (long) method to start with.
| @@ -592,6 +616,24 @@ public Logger getLog( String name ) | |||
| return GraphDatabase.driver( boltUri, clusterRule.getDefaultAuthToken(), config ); | |||
| } | |||
|
|
|||
| private Driver discoverDriver( List<String> addresses ) | |||
| { | |||
| Logging devNullLogging = new Logging() | |||
There was a problem hiding this comment.
DevNullLogging.DEV_NULL_LOGGING constant can be used instead
| * This is wrapper for the {@link #driver} method that finds the first | ||
| * server to respond positively. | ||
| * | ||
| * @param addresses a list of server addresses for Neo4j instances |
There was a problem hiding this comment.
Could we mention that address is host or host:port without scheme?
|
@lutovich This will actually be for 1.4. Good point. |
zhenlineo
reviewed
May 23, 2017
| * @param config user defined configuration | ||
| * @return a new driver instance | ||
| */ | ||
| public static Driver routingDriverFromFirstAvailableAddress( List<String> addresses, AuthToken authToken, Config config ) |
There was a problem hiding this comment.
Can we do something like
public static Driver routingDriver( List<URI> uris, AuthToken authToken, Config config )
{
for( URI uri: uris )
{
assertRoutingScheme( uri );
try
{
return driver( uri, authToken, config );
}
catch( ServiceUnavailableException e )
{
// try the next one
}
}
throw new ServiceUnavailableException( "Failed to discover an available server" );
}
private static void assertRoutingScheme( uri )
{
if( !uri.getScheme().equals("bolt+routing") )
{
throw new IllegalArgumentException( "Unsupported scheme " + uri.getScheme() + " for routing driver. Supported scheme is 'bolt+routing'. " );
}
}
| * @param authToken authentication to use, see {@link AuthTokens} | ||
| * @return a new driver instance | ||
| */ | ||
| public static Driver routingDriverFromFirstAvailableAddress( List<String> addresses, AuthToken authToken ) |
There was a problem hiding this comment.
I would also vote for a single (long) method to start with.
* use shorter name `routingDriver` instead of `routingDriverFromFirstAvailableAddress` * no overloads * take `Iterable<URI>` of server URIs and verify 'bolt+routing' scheme * introduce constants for URIs schemes
lutovich
force-pushed
the
1.3-first-available-address
branch
from
3da70e9 to
2dab779
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.