Add unresolved inital router address to list of resolved initial roter addresses #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er addresses In scenarios with SNI, connecting to resolved addresses does not work. To retain the multi-record DNS capability for bootstrap address, add the unresolved address after the resolved addresses. Co-Authored-By: Tobias Johansson <tobias.johansson@neotechnology.com>
|
@jjaderberg Could you give a try of the fix proposed by #566 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios with SNI, connecting to resolved addresses does not work.
The driver consistently fails to retrieve a routing table using the
initialRouterbecause the address is explicitly resolved before making connection(s). It succeeds to get a routing table only because the same initial address is also put into the table as a router.By adding the initial router address unresolved to the list of addresses to try, the driver should be able to work both with SNI and with multi-record DNS bootstrap addresses.