Change how BoltServerAddress equality works #592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoltServerAddress was checking equality on
Hostname
,Resolved IP
andPort
triplet and DnsResolver was causing loss of originalHostname
.This commit removed public access to resolved IP Address component of BoltServerAddress and removes it from the equality check, thus resulting in same
hostname:port
pairs equal whatever IP address they are resolved to.Also removed DnsResolver since it returns a set of addresses (which would not allow same
hostname:port
pairs resolved to different IP addresses) and offloaded the dns resolution to take place just after custom address resolution (default is identity resolver) happens.