Byte array support #250
Merged
Byte array support #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes driver handle writing and reading of byte arrays. They are represented as instances of Int8Array class. Driver will fail-fast when server does not support byte arrays and will not even attempt to send the given array.
This commit adds optional logging of open sockets, file handles, etc. to the gulp script. Logging happens after various NodeJS test task that can theoretically leave unclosed resources after execution. Logging is turned off by default. It happened to be very useful when NodeJS process does not exit after tests because of open `TLSSocket` objects.
To assert that both `DirectConnectionProvider` and `LoadBalancer` return promises with initialized connections.
They were failing because of incorrect artificial Neo4j version. Also fixes JS doc visibility modifier in driver.
Commit moves waiting for connection initialization promise higher in the stack - from `ConnectionProvider` to `ConnectionHolder`. This is needed to be able to notify stream observer about used connection even if initialization fails. It is later possible to purge connections for the given server. Previously stream observer did not get to know the connection and pool was not purged on connectivity errors.
lutovich
force-pushed
the
1.4-byte-arrays
branch
from
f004395 to
4e33fc9
Compare
lutovich
force-pushed
the
1.4-byte-arrays
branch
from
f7b9f7d to
b44296c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow driver to receive and send byte arrays. They are represented by instances of
Int8Arrayclass. Feature only supported by 3.2+ servers and driver performs version check to fail early.