Remove circular dependencies #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
force-pushed
the
4.3-remove-cyclic-dependencies
branch
from
2f38157 to
a6c9fe0
Compare
2hdddg
approved these changes
Jan 14, 2021
| @@ -30,9 +29,9 @@ function encode (str) { | |||
| } | |||
|
|
|||
| function decode (buffer, length) { | |||
| if (buffer instanceof NodeBuffer) { | |||
| if (Object.prototype.hasOwnProperty.call(buffer, '_buffer')) { | |||
There was a problem hiding this comment.
Looks like there should be a decode function on NodeBuffer and CombinedBuffer
There was a problem hiding this comment.
Yes, It should be a method present in all the buffers versions, the issue is way it's done vary a bit between buffer types, I could not figure out a way to do it properly.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove circular dependencies to decouple modules.
Circular dependencies overview: