Fix log message doesn't appearing correctly in the Bolt log. #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The write and receive message functions were moved from the connection to the `response-handler` and `bolt-protocol`, but logs on the functions still creating the message using the `this`, but in the nnew context the value of `this` is not serialized as the connection id. Since the connection id data is dynamic and the depends on a response from the server, the issue was solved decorating the logger function to add connection context information.
bigmontz
force-pushed
the
4.3-fix-log-message
branch
from
2ffec4a to
077294a
Compare
fbiville
approved these changes
Jun 11, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The write and receive message functions were moved from the connection to the
response-handlerandbolt-protocol, but logs on the functions still creating the message using thethis, but in the nnew context the value ofthisis not serialized as the connection id.Since the connection id data is dynamic and the depends on a response from the server, the issue was solved decorating the logger function to add connection context information.