Connection Hint: supporting connection.recv_timeout_seconds #761
Conversation
This value defines the time the client should wait for a response on a connection before it times out. Co-authored-by: Rouven Bauer <rouven.bauer@neotechnology.com>
| const receiveTimeoutInSeconds = toNumber(receiveTimeoutRaw) | ||
| if (receiveTimeoutInSeconds > 0) { |
There was a problem hiding this comment.
Not sure if even feasible in JS's limited number type, but we also don't expect floats from the server.
There was a problem hiding this comment.
I will create tests with float number to limit this option. One question, should 3.0 be considered an invalid value?
There was a problem hiding this comment.
I don't know how the JS drivers handles numbers internally. But the server is expected to sent an Integer (strongly typed through packstream). It might well be, however, that at this point in the code, the type information is already lost. In that case, I'd say 3.0 is also ok.
There was a problem hiding this comment.
At that point, I already lost this information. Since 3 is the same as 3.0 for JS. So, I'm verifying if it's a Integer using the JS Number definition of integer.
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
bigmontz
force-pushed
the
4.3-connection-hint-receive_timeout_seconds
branch
from
4ded350 to
da448b8
Compare
bigmontz
force-pushed
the
4.3-connection-hint-receive_timeout_seconds
branch
from
da448b8 to
ad7ec10
Compare
This value defines the time the client should wait for a response on a connection before it times out.
Co-authored-by: Rouven Bauer rouven.bauer@neotechnology.com