Skip to content

Don't try to rollback a closed transaction #531

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2021
Merged

Don't try to rollback a closed transaction #531

merged 2 commits into from
Apr 12, 2021

Conversation

robsdedude
Copy link
Member

Let the transaction object decide if a rollback makes sense on a failed transaction. The transaction might have already been closed.

Note that tx.close() is a noop on closed transactions.

@robsdedude robsdedude requested a review from technige April 7, 2021 15:40
@robsdedude robsdedude merged commit aeaf7a7 into neo4j:4.3 Apr 12, 2021
@robsdedude robsdedude deleted the fix-dont-try-to-rollback-closed-transaction branch April 12, 2021 11:56
@meseta meseta mentioned this pull request Apr 25, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@technige technige technige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @technige