Skip to content

.run on a failed transaction will also fail #566

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Jul 20, 2021

Mark a transaction as broken on .run failure.

If executing a query fails (for whatever reason), the server will terminate the
transaction. So we might as well mark the transaction as broken on the driver
side and fail fast (before contacting the server), should the client code try to
use the transaction again.

@robsdedude robsdedude force-pushed the run-on-failed-tx branch 3 times, most recently from 44f69bb to 2c0860e Compare July 21, 2021 07:16
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@robsdedude robsdedude merged commit 30613cc into neo4j:4.4 Jul 21, 2021
@robsdedude robsdedude deleted the run-on-failed-tx branch July 21, 2021 08:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants