[4.3] Fix removing connection twice from pool. #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to close a stale connection the driver count realize that the connection is dead on trying to send GOODBYE. This would cause the connection to make sure that all connections to the same address would get removed from the pool as well. Since this removal only happens as a side effect of `connection.close()` and does not always happen, the driver would still try to remove the (now already removed) connection form the pool after closure. Fixes: `ValueError: deque.remove(x): x not in deque`
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to close a stale connection the driver count realize that the
connection is dead on trying to send GOODBYE. This would cause the connection
to make sure that all connections to the same address would get removed from
the pool as well. Since this removal only happens as a side effect of
connection.close()and does not always happen, the driver would still tryto remove the (now already removed) connection form the pool after closure.
Fixes:
ValueError: deque.remove(x): x not in deque