Type extractors for common container types #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- impl TryIntoJs for RefCell - impl TryFromJs for &RefCell
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
+ Coverage 83.05% 83.40% +0.34%
==========================================
Files 73 74 +1
Lines 5472 5533 +61
Branches 5472 5533 +61
==========================================
+ Hits 4545 4615 +70
+ Misses 810 803 -7
+ Partials 117 115 -2 ☔ View full report in Codecov by Sentry. |
- impl TryIntoJs for Rc - impl TryFromJs for Rc - impl TryIntoJs for Arc - impl TryFromJs for Arc - impl TryIntoJs for Mutex - impl TryFromJs for &Mutex - impl TryFromJs for MutexGuard also a couple more RefCell conveniences: - impl TryFromJs for Ref - impl TryFromJs for RefMut
kjvalencik
reviewed
Feb 2, 2025
- just use TypeExpected for type errors - just use panic for dynamic borrow errors - eliminate RustTypeExpected and RefCellError types completely - eliminate Container trait
…comments, but just throw instead of a custom error type
kjvalencik
reviewed
Feb 3, 2025
kjvalencik
approved these changes
Feb 3, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement type extractors for common container types in the standard library, so that they don't required explicit
Boxedwrapping withJsBoxin userland.Implemented so far:
RefCellimpl TryIntoJs for RefCellimpl TryFromJs for &RefCellimpl TryFromJs for Refimpl TryFromJs for RefMutRcimpl TryIntoJs for Rcimpl TryFromJs for RcArcimpl TryIntoJs for Arcimpl TryFromJs for Arc