Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pageserver: don't periodically flush layers for stale attachments #11317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erikgrinaker
Copy link
Contributor

Problem

Tenants in attachment state Stale can't upload layers, and don't run compaction, but still do periodic L0 layer flushes in the tenant housekeeping loop. If the tenant remains stuck in stale mode, this causes a large buildup of L0 layers, causing logging, metrics increases, and possibly alerts.

Resolves #11245.

Summary of changes

Don't perform periodic layer flushes in stale attachment state.

@erikgrinaker erikgrinaker requested a review from a team as a code owner March 19, 2025 20:32
@erikgrinaker erikgrinaker requested a review from problame March 19, 2025 20:32
@erikgrinaker erikgrinaker enabled auto-merge March 19, 2025 20:32
Copy link

7964 tests run: 7580 passed, 0 failed, 384 skipped (full report)


Code coverage* (full report)

  • functions: 32.4% (8731 of 26955 functions)
  • lines: 48.4% (74851 of 154549 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4904091 at 2025-03-19T21:32:59.507Z :recycle:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: don't do periodic layer rolls in AttachedStale state
1 participant