Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

TASK: Fix reflection test #3434

Merged
merged 1 commit into from
Jan 16, 2025
Merged

TASK: Fix reflection test #3434

merged 1 commit into from
Jan 16, 2025

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Jan 15, 2025 •
edited
Loading

With 9.0 we get more data from ReflectionService::getMethodParameters so the test needs to get adapted.

See: #3086

@dlubitz dlubitz requested a review from mhsdesign January 16, 2025 11:41
mhsdesign
mhsdesign approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes totally sense thanks!

@mhsdesign mhsdesign merged commit a1af25e into neos:9.0 Jan 16, 2025
8 checks passed
@dlubitz dlubitz deleted the task/reflection-test branch January 16, 2025 14:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlubitz @mhsdesign