Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FEATURE: Ensure unique form element identifier with a CommandHook #142

Merged

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Nov 7, 2024

@dlubitz dlubitz force-pushed the feature/command-hook-for-identifier-uniqueness branch from 49dd906 to 89cec42 Compare November 7, 2024 16:30
@bwaidelich bwaidelich marked this pull request as ready for review November 12, 2024 11:23
@bwaidelich bwaidelich merged commit 3c8438d into neos:main Nov 12, 2024
@bwaidelich
Copy link
Member

@dlubitz oops, I accidentally merged this one due to my trigger-happy mood.. Shall I create a revert-PR or is it fine in your opinion?

@dlubitz
Copy link
Contributor Author

dlubitz commented Nov 12, 2024

Yeah.... the main is not yet 9.0 ready because of the missing PR mentioned above. But I guess it's fine. I'll create branch for latest minor version and main will become WIP for Neos 9.0

@dlubitz dlubitz deleted the feature/command-hook-for-identifier-uniqueness branch November 12, 2024 11:26
@bwaidelich
Copy link
Member

As discussed:
The 2.3 branch is up-to-date so we can create a 3.0 branch with Neos 9+ compatibility and try to get #133 merged asap

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants