cleanup lsp config with new root_dir behaviour

[emilioziniades]

Language server

No response

Requested feature

Now that #2885 has been merged, we can clean up a bunch of language server configs that had to manually specify priorities of patterns for finding the root directory. For example, in tsserver, this

nvim-lspconfig/lua/lspconfig/server_configurations/tsserver.lua

Lines 15 to 18 in 90a28fd

	root_dir = function(fname)
	return util.root_pattern 'tsconfig.json'(fname)
	or util.root_pattern('package.json', 'jsconfig.json', '.git')(fname)
	end,

can simply become

return util.root_pattern('tsconfig.json', 'package.json', 'jsconfig.json', '.git')

Anywhere where a language server has something like return util.root_pattern(pattern1) or util.root_pattern(pattern2) or ... can be simplified.

Here's a list of language servers I've identified:

nvim-lspconfig/lua/lspconfig/server_configurations/cairo_ls.lua

Lines 11 to 14 in 7384e71

	root_dir = function(fname)
	return util.root_pattern 'Scarb.toml'(fname)
	or util.root_pattern('Scarb.toml', 'cairo_project.toml', '.git')(fname)
	end,

nvim-lspconfig/lua/lspconfig/server_configurations/custom_elements_ls.lua

Lines 7 to 10 in 7384e71

	root_dir = function(fname)
	return util.root_pattern 'tsconfig.json'(fname)
	or util.root_pattern('package.json', 'jsconfig.json', '.git')(fname)
	end,

nvim-lspconfig/lua/lspconfig/server_configurations/gopls.lua

Line 23 in 7384e71

return util.root_pattern 'go.work'(fname) or util.root_pattern('go.mod', '.git')(fname)

nvim-lspconfig/lua/lspconfig/server_configurations/gradle_ls.lua

Line 20 in 7384e71

return util.root_pattern(unpack(root_files))(fname) or util.root_pattern(unpack(fallback_root_files))(fname)

nvim-lspconfig/lua/lspconfig/server_configurations/hls.lua

Lines 8 to 11 in 7384e71

	return (
	util.root_pattern('hie.yaml', 'stack.yaml', 'cabal.project')(filepath)
	or util.root_pattern('*.cabal', 'package.yaml')(filepath)
	)

nvim-lspconfig/lua/lspconfig/server_configurations/kotlin_language_server.lua

Line 29 in 7384e71

return util.root_pattern(unpack(root_files))(fname) or util.root_pattern(unpack(fallback_root_files))(fname)

nvim-lspconfig/lua/lspconfig/server_configurations/omnisharp.lua

Lines 41 to 49 in 7384e71

	root_dir = function(fname)
	local root_patterns = { '*.sln', '*.csproj', 'omnisharp.json', 'function.json' }
	for _, pattern in ipairs(root_patterns) do
	local found = util.root_pattern(pattern)(fname)
	if found then
	return found
	end
	end
	end,

nvim-lspconfig/lua/lspconfig/server_configurations/syntax_tree.lua

Line 8 in 7384e71

return util.root_pattern '.streerc'(fname) or util.root_pattern('Gemfile', '.git')(fname)

nvim-lspconfig/lua/lspconfig/server_configurations/tailwindcss.lua

Lines 103 to 106 in 7384e71

	return util.root_pattern('tailwind.config.js', 'tailwind.config.cjs', 'tailwind.config.mjs', 'tailwind.config.ts')(
	fname
	) or util.root_pattern('postcss.config.js', 'postcss.config.cjs', 'postcss.config.mjs', 'postcss.config.ts')(
	fname

nvim-lspconfig/lua/lspconfig/server_configurations/tsserver.lua

Lines 15 to 18 in 7384e71

	root_dir = function(fname)
	return util.root_pattern 'tsconfig.json'(fname)
	or util.root_pattern('package.json', 'jsconfig.json', '.git')(fname)
	end,

nvim-lspconfig/lua/lspconfig/server_configurations/vtsls.lua

Lines 14 to 17 in 7384e71

	root_dir = function(fname)
	return util.root_pattern 'tsconfig.json'(fname)
	or util.root_pattern('package.json', 'jsconfig.json', '.git')(fname)
	end,

Let me know if I have missed any.

cc @glepnir @justinmk

Other clients which have this feature

No response

[justinmk]

🚀