fix: cleanup root patterns #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilioziniades
force-pushed
the
feature/cleanup-root-patterns
branch
from
f8fbbf4 to
afd6441
Compare
glepnir
approved these changes
Nov 20, 2023
justinmk
reviewed
Nov 20, 2023
| @@ -27,7 +24,7 @@ require'lspconfig'.cairo_ls.setup{} | |||
| *cairo-language-server is still under active development, some features might not work yet !* | |||
| ]], | |||
| default_config = { | |||
| root_dir = [[root_pattern("package.json", "tsconfig.json", "jsconfig.json", ".git")]], | |||
| root_dir = [[root_pattern("Scarb.toml", "cairo_project.toml", ".git")]], | |||
There was a problem hiding this comment.
were the "package.json", "tsconfig.json" entries accidental?
There was a problem hiding this comment.
I assume so. The docs didn't match the root_dir field above so I just updated the two to match whilst I was in there.
justinmk
approved these changes
Nov 20, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
root_dirin multiple language server configurations where root patterns needed to be prioritised.util.root_patternnow prioritises root patterns provided first - see #2885.Closes #2904