Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP: Can not combine URL params and body #68

Closed
wants to merge 3 commits into from

Conversation

fortmarek
Copy link

Hi!

To resolve this issue I need a way to define URL query parameters and also be able to add a body - as per github API documentation.
This does not seem to be possible at the moment (or I could not find a way to do this).
Even more weirdly, if I define some params and set HTTPEncoding to .url, the params are still encoded into JSON in post function which does not seem to be right.

Currently, I have tried to make minimal changes to the codebase while achieving what I want, but for a proper solution there'd probably have to be breaking changes (as of now the change is only additive).

Let me know if you feel like this is a way to go or if I should take a completely different path 🙂

@fortmarek fortmarek changed the title Can not combine URL params and body WIP: Can not combine URL params and body Jul 8, 2020
@pietbrauer
Copy link
Member

@fortmarek Whats the state of this PR? I haven't looked at it until now because it had WIP In the name. I'm quite happy with your changes and would appreciate some tests for the new functionality.

@fortmarek
Copy link
Author

hi @pietbrauer, I don't really have time to finish this PR. If anyone else needs this, they are free to take this to the finish line 🙂

@fortmarek fortmarek closed this Feb 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload Assets
2 participants