Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

implement download csv #1241

Merged
merged 11 commits into from
May 26, 2023
Merged

implement download csv #1241

merged 11 commits into from
May 26, 2023

Conversation

iamyates
Copy link
Contributor

@iamyates iamyates commented Apr 20, 2023 •
edited
Loading

@iamyates iamyates self-assigned this Apr 20, 2023
@iamyates iamyates marked this pull request as draft April 20, 2023 07:08
@iamyates iamyates mentioned this pull request Apr 20, 2023
Closed
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 68.00% and project coverage change: +0.41 🎉

Comparison is base (c31132d) 58.88% compared to head (883a748) 59.29%.

❗ Current head 883a748 differs from pull request most recent head 65005d7. Consider uploading reports for the commit 65005d7 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1241      +/-   ##
===========================================
+ Coverage    58.88%   59.29%   +0.41%     
===========================================
  Files          267      267              
  Lines         7635     7727      +92     
===========================================
+ Hits          4496     4582      +86     
- Misses        3139     3145       +6
Impacted Files Coverage Δ
app/models/deployed_cell.rb 72.36% <22.22%> (+14.26%) ⬆️
app/controllers/api/v1/udts_controller.rb 68.00% <44.82%> (-32.00%) ⬇️
...trollers/api/v1/address_transactions_controller.rb 83.92% <68.00%> (-12.85%) ⬇️
app/controllers/api/v2/nft/transfers_controller.rb 91.48% <95.45%> (+3.48%) ⬆️
app/controllers/api/v1/blocks_controller.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iamyates iamyates marked this pull request as ready for review May 14, 2023 12:37
@iamyates iamyates enabled auto-merge (squash) May 14, 2023 12:38
@iamyates iamyates requested a review from ShiningRay May 14, 2023 12:38
@iamyates iamyates added the enhancement New feature or request label May 14, 2023
@iamyates iamyates mentioned this pull request May 15, 2023
Closed
auto-merge was automatically disabled May 22, 2023 03:02

Merge queue setting changed

@Keith-CY Keith-CY requested a review from zmcNotafraid May 26, 2023 02:00
@iamyates iamyates added this pull request to the merge queue May 26, 2023
Merged via the queue into nervosnetwork:develop with commit 3d0d561 May 26, 2023
@iamyates iamyates deleted the 2023_04_20_save_as_csv branch May 26, 2023 07:16
ShiningRay added a commit to ShiningRay/ckb-explorer that referenced this pull request May 29, 2023
@ShiningRay
Merge branch 'develop' into feat/websocket
919d797 
* develop:
  implement download csv (nervosnetwork#1241)
  fix cache deletion
  Deploy to testnet (nervosnetwork#1286)

# Conflicts:
#	app/models/address.rb
#	app/models/ckb_sync/node_data_processor.rb
@rabbitz rabbitz mentioned this pull request Jun 2, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ShiningRay ShiningRay ShiningRay approved these changes

@zmcNotafraid zmcNotafraid Awaiting requested review from zmcNotafraid

Assignees

@iamyates iamyates

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamyates @codecov-commenter @ShiningRay