validatePredefined has no effect unless the deprecated ignoreEnvVars is set

[vincentrolfs]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

Line 68 in config.module.ts has a bug. It says:

if (!options.ignoreEnvVars || options.validatePredefined) {
      config = {
        ...config,
        ...process.env,
      };
}

But the docs say that ignoreEnvVars is deprecated, and one should use validatePredefined instead. But if we do that, then ignoreEnvVars will be unset and thus falsey. Meaning validatePredefined has no effect.

Minimum reproduction code

config/lib/config.module.ts

Line 68 in 1694ea6

if (!options.ignoreEnvVars || options.validatePredefined) {

Steps to reproduce

No response

Expected behavior

Correct code should be

if (!options.ignoreEnvVars && (options.validatePredefined !== false)) {
      config = {
        ...config,
        ...process.env,
      };
}

Package version

11

NestJS version

11

Node.js version

No response

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

[kamilmysliwiec]

Would you like to create a PR for this issue?