Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: use getAllMethodNames method #1448

Merged

Conversation

peixotoleonardo
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

ScheduleExplorer is using scanFromPrototype of the MetadataScanner, this method is deprecated.

Issue Number: N/A

What is the new behavior?

I used the method getAllMethodNames for doing the same thing of the scanFromPrototype method

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec changed the title refactor: use setAllMethodNames method refactor: use getAllMethodNames method Oct 23, 2023
@kamilmysliwiec kamilmysliwiec merged commit a66dc3e into nestjs:master Oct 23, 2023
@kamilmysliwiec
Copy link
Member

LGTM

@peixotoleonardo peixotoleonardo deleted the refactor/schedule.explorer branch October 23, 2023 21:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants