Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[client] Fix a panic on shutdown if dns host manager failed to initialize #3182

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Jan 14, 2025

Describe your changes

If the inner host manager init fails, we will be left with a non-nil s.hostManager despite the inner value being nil. Any s.hostManager != nil check will pass, but method calls on this struct will panic.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lixmal lixmal merged commit b34887a into main Jan 15, 2025
43 checks passed
@lixmal lixmal deleted the fix-dns-mgr-panic branch January 15, 2025 12:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants