Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[relay] Use new upstream for nhooyr.io/websocket package #3287

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Feb 5, 2025

The nhooyr.io/websocket package was renamed to github.com/coder/websocket when the project was transferred to "coder" as the new maintainer.

Use the new import path and update go.mod and go.sum accordingly.

See #3240 cc @lixmal

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

@paralin paralin changed the title refactor: use new upstream for nhooyr.io/websocket package Use new upstream for nhooyr.io/websocket package Feb 5, 2025
The nhooyr.io/websocket package was renamed to github.com/coder/websocket when
the project was transferred to "coder" as the new maintainer.

Use the new import path and update go.mod and go.sum accordingly.

Signed-off-by: Christian Stewart <christian@aperture.us>
@paralin paralin changed the title Use new upstream for nhooyr.io/websocket package [relay] Use new upstream for nhooyr.io/websocket package Feb 5, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

@paralin
Copy link
Contributor Author

paralin commented Feb 5, 2025

Hey @lixmal - the test that failed here:

func BenchmarkLoginPeer_ExistingPeer(b *testing.B) {

It seems to have failed because it took 51.64 ms/op, maximum 35.00 ms/op - 16 ms longer than usual?

Does that code even use websocket at all, though? As far as I can see websocket is just used in relay.

Could this just be a test flake? Thanks!

@lixmal
Copy link
Contributor

lixmal commented Feb 5, 2025

It's just a flake.

Thanks for the PR, appreciate it!

@lixmal lixmal merged commit fe370e7 into netbirdio:main Feb 5, 2025
40 of 41 checks passed
@paralin
Copy link
Contributor Author

paralin commented Feb 5, 2025

@lixmal No problem, thank you for addressing this so quickly.

@paralin paralin deleted the coder-websocket branch February 5, 2025 22:08
lixmal pushed a commit that referenced this pull request Feb 6, 2025
The nhooyr.io/websocket package was renamed to github.com/coder/websocket when
the project was transferred to "coder" as the new maintainer.

Use the new import path and update go.mod and go.sum accordingly.

Signed-off-by: Christian Stewart <christian@aperture.us>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants