Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: Some compiler warnings with musl #5421

Closed
rusty-snake opened this issue Oct 13, 2022 · 2 comments · Fixed by #5431
Closed

build: Some compiler warnings with musl #5421

rusty-snake opened this issue Oct 13, 2022 · 2 comments · Fixed by #5431

Comments

@rusty-snake
Copy link
Collaborator

Some compiler warnings. Not critical but they will fail the build with --enable-fatal-warnings.

Firejail: 65c5480
gcc: gcc (Alpine 11.2.1_git20220219) 11.2.1 20220219

main.c:193: warning: "LINE_MAX" redefined
  193 | #define LINE_MAX 200
      | 
In file included from /usr/include/fortify/stdlib.h:29,
                 from ../include/common.h:27,
                 from fnettrace.h:23,
                 from main.c:20:
/usr/include/limits.h:84: note: this is the location of the previous definition
   84 | #define LINE_MAX 4096
      | 
libtracelog.c:43:23: warning: 'orig_fopen64' defined but not used [-Wunused-variable]
   43 | static orig_fopen64_t orig_fopen64 = NULL;
      |                       ^~~~~~~~~~~~
libtrace.c:48:23: warning: 'orig_fopen64' defined but not used [-Wunused-variable]
   48 | static orig_fopen64_t orig_fopen64 = NULL;
      |  
@reinerh
Copy link
Collaborator

reinerh commented Oct 14, 2022

Interesting that it doesn't happen in the CI, where fatal warnings are enabled.

@reinerh
Copy link
Collaborator

reinerh commented Oct 23, 2022

The difference to our CI is that Alpine builds with musl.

@rusty-snake Can you please try building on Alpine with #5431?

@kmk3 kmk3 changed the title Some compiler warnings Some compiler warnings when building with musl Nov 3, 2022
kmk3 added a commit that referenced this issue Nov 3, 2022
@kmk3 kmk3 changed the title Some compiler warnings when building with musl build: Some compiler warnings with musl Nov 3, 2022
@kmk3 kmk3 moved this to Done (on RELNOTES) in Release 0.9.72 Sep 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging a pull request may close this issue.

2 participants