Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New profile: hledger/hledger-ui #6585

Merged
merged 1 commit into from
Feb 10, 2025
Merged

New profile: hledger/hledger-ui #6585

merged 1 commit into from
Feb 10, 2025

Conversation

amano-kenji
Copy link
Contributor

@amano-kenji amano-kenji commented Dec 27, 2024

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both profiles are nearly identical, so I don't see a need for a -common
profile.

To simplify it:

  • Move hledger-common into hledger
  • Make hledger-ui redirect to hledger
  • Remove hledger-common

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to add private-etc entries to the new profiles?

You can check what paths a program tries to access with --trace=.

Example:

firejail --trace=trace.txt /usr/bin/foo

The output in trace.txt should contain the relevant /etc paths.

Other than program-specific files, generally a profile will have private @network,@tls-ca if it needs internet access and private-etc @x11 if it has
a GUI.

See src/include/etc_groups.h for the other groups.


Also, #6593 was merged and it catches (among other things) a missing newline at
EOF (which affects some of the open PRs), so please rebase all PRs to master.

@kmk3 kmk3 merged commit a2e97e9 into netblue30:master Feb 10, 2025
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants