Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: remove redundant environment variable #180

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore: remove redundant environment variable #180

merged 1 commit into from
Oct 3, 2024

Conversation

mfiedorowicz
Copy link
Member

Re: #179

@mfiedorowicz
chore: remove redundant environment variable
0a16d79 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz self-assigned this Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.23s github.com/netboxlabs/diode/diode-server/ingester 4.3% 9 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.56s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 3.2% 40 0 0
🟢 PASS 1.44s github.com/netboxlabs/diode/diode-server/reconciler 12.4% 65 0 0
🟢 PASS 1.49s github.com/netboxlabs/diode/diode-server/reconciler/changeset 34.2% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 80.0%

leoparente
leoparente approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfiedorowicz mfiedorowicz merged commit b615173 into develop Oct 3, 2024
5 checks passed
@mfiedorowicz mfiedorowicz deleted the chore-tidy-up-env-vars branch October 3, 2024 08:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@leoparente leoparente leoparente approved these changes

Assignees

@mfiedorowicz mfiedorowicz

Labels
diode-server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfiedorowicz @leoparente