Add adapters from filter and find services to eZ search service #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emodric
force-pushed
the
service_adapters
branch
from
0b783e4 to
3a2fa7c
Compare
MarioBlazek
approved these changes
Dec 12, 2017
pspanja
reviewed
Dec 13, 2017
lib/Resources/config/services.yml
Outdated
| public: false | ||
| arguments: | ||
| - "@netgen.ezplatform_site.find_service" | ||
| - "@ezpublish.spi.search.solr" |
There was a problem hiding this comment.
This should really use ezpublish.spi.search_engine since it's not a given Solr is configured as search engine.
Looks good otherwise :)
There was a problem hiding this comment.
Hm... Okay. I presume ezpublish.spi.search.legacy is fine for filter adapter?
There was a problem hiding this comment.
Yes, that's hardcoded in the config here.
emodric
force-pushed
the
service_adapters
branch
from
3a2fa7c to
5dab69c
Compare
pspanja
approved these changes
Dec 13, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes are adapters from Site API filter and find services to SearchService interface
from eZ Publish kernel. The point is being able to replace usage of eZ search service
with Site API filter or find service without touching consuming code.
Ofcourse, we need to convert value objects in search hits from Site API to eZ API value objects.
Methods implemented here do not use
$languageFilterargument since it is handled automaticallyby the filter and find services themselves.
As for
$filterOnUserPermissions, filter and find services don't support it, so it is simply ignored.Ran some basic tests with replaced services, and it works fine.