-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[NAE-2033] Welcome dashboard #285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement auto-select for menu items
- create processes for managing dashboards - dashboard_management and dashboard_item - create runner for importing dashboard management processes
- added option to load icon from web (image from web) - added option to change dashboard toolbar logo - added option to chane appearance of dashboard toolbar
- added option to change icon and font colors in dashboard items - fix for items ordering
Retoocs
requested changes
Feb 10, 2025
src/main/resources/petriNets/engine-processes/dashboard_item.xml
Outdated
Show resolved
Hide resolved
src/main/resources/petriNets/engine-processes/dashboard_management.xml
Outdated
Show resolved
Hide resolved
} | ||
change dashboard_item_to_preference_item options { preferenceItemOptions } | ||
|
||
def dashboardItemCases = findCasesElastic("processIdentifier:\"dashboard_item\" AND dataSet.is_active.booleanValue:true" as String, org.springframework.data.domain.PageRequest.of(0, 1000)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe page size should be configurable with default value? (question for all of the elastic requests)
mazarijuraj
previously approved these changes
Feb 11, 2025
src/main/groovy/com/netgrif/application/engine/startup/DashboardManagementRunner.groovy
Outdated
Show resolved
Hide resolved
- add option to change profile and login urls
- change default value of login url to empty string
- update by PR comments - create findCasesElastic method in ActionDelegate with default page size of 1000 items - check duplicate ids in dashboard_item and dashboard_management in finish action - move importProcess function into ImportHelper and clean runners
Retoocs
requested changes
Feb 14, 2025
...vy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy
Outdated
Show resolved
Hide resolved
- documentation
Retoocs
previously approved these changes
Feb 14, 2025
Retoocs
reviewed
Feb 14, 2025
...vy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy
Outdated
Show resolved
Hide resolved
- change default page size to 100 in findCasesElastic
Retoocs
approved these changes
Feb 14, 2025
mazarijuraj
approved these changes
Feb 17, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
improvement
A change that improves on an existing feature
new feature
A change that introduces new functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements configurable dashboard component. Component is managed by process dashboard_management and displays dashboard items (dashboard_item process) in tile view.
Configuration available in dashboard:
Configuration for dashboard items:
Implements NAE-2033
Dependencies
No new dependencies were introduced.
Third party dependencies
No new dependencies were introduced.
Blocking Pull requests
Depends on #(283)
How Has Been This Tested?
Manually from application
Checklist: