Skip to content

Fix issue with scanning subfolders if ignoreDirectories is not used #35

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

Finholt
Copy link
Contributor

@Finholt Finholt commented Oct 30, 2020

I noticed that if I did not set ignoreDirectories...

[plugins.inputs]
  checkPaths = ['/']
  # ignoreDirectories = ['/admin']
  resultMode = "warn"

...then none of the subfolders were being scanned. This appears to be because directoryFilter can be used both exclusively and inclusively.

When used with ignoreDirectories, it was being interpreted as "exclude these paths" (as expected), but if it was not set, it was being interpreted as "include no paths"

@mxmason
Copy link
Contributor

mxmason commented Oct 25, 2021

Hi, @Finholt! Thank you so much for writing this fix, and your patience with us in getting back to you!

@mxmason mxmason merged commit 9e368c1 into netlify-labs:master Oct 25, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants