Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

fix(npm): allow multiple NPM_FLAGS during new install execution #900

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

JGAntunes
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Follow up to - #854. With it we indroduced a regression for #496. This should address it.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update the included software doc (if you updated included software) 📄
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@JGAntunes JGAntunes self-assigned this Jan 23, 2023
@JGAntunes JGAntunes requested review from a team and jobala January 23, 2023 13:25
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 23, 2023
@JGAntunes JGAntunes merged commit 4229d94 into focal Jan 23, 2023
@JGAntunes JGAntunes deleted the fix/multiple-npm-flags branch January 23, 2023 14:27
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants