Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

chore: run pre & post install scripts #854

Merged
merged 6 commits into from
Oct 24, 2022
Merged

Conversation

jobala
Copy link
Contributor

@jobala jobala commented Oct 19, 2022

Summary

Fixes #523

Screenshot 2022-10-24 at 12 50 01

Removes the cache check and always runs npm install

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update the included software doc (if you updated included software) 📄
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@jobala jobala requested a review from a team October 19, 2022 09:02
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@jobala jobala changed the title run pre & post install scripts chore: run pre & post install scripts Oct 19, 2022
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 19, 2022
Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from looking at it. Can you maybe write a bats test for it? especially the thing with the feature flag?

@jobala jobala requested a review from lukasholzer October 24, 2022 09:40
Copy link
Contributor

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 left a small set of comments

run-build-functions.sh Show resolved Hide resolved
tests/node/bypass_cache.bats Show resolved Hide resolved
@jobala jobala requested a review from JGAntunes October 24, 2022 11:49
Copy link
Contributor

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jobala jobala enabled auto-merge (squash) October 24, 2022 13:32
@jobala jobala merged commit 5a7cdf3 into focal Oct 24, 2022
@jobala jobala deleted the chore/run-pre-and-post-scripts branch October 24, 2022 13:46
@itsjoekent itsjoekent mentioned this pull request Oct 24, 2022
6 tasks
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm preinstall and postinstall scripts are not run
3 participants