feat: add support for streaming functions #5725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 13226a4 Package size: 233 MB⬇️ 0.03% decrease vs. 13226a4 Legend
|
Skn0tt
previously approved these changes
May 15, 2023
| const { stream } = require("@netlify/functions"); | ||
|
|
||
| class TimerSource { | ||
| #input; |
There was a problem hiding this comment.
TIL that private class fields have been supported since Node v12!
| chunks.push(chunk.toString()) | ||
| }) | ||
|
|
||
| await pause(500) |
There was a problem hiding this comment.
let's add an assertion on the arrival times of the chunks, to ensure that local dev isn't buffering the response. i've been bitten by that before.
Skn0tt
approved these changes
May 15, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for streaming functions in Netlify Dev.
Part of https://github.com/netlify/pod-compute/issues/466.