Skip to content

feat!: run build by default before deploy #7195

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ndhoule
Copy link
Contributor

@ndhoule ndhoule commented Apr 10, 2025

  • refactor: type commander options in deploy command
  • refactor: do all argv parsing in createDeployCommand
  • feat!: run build before deploy

Copy link

📊 Benchmark results

Comparing with 33b60ba

  • Dependency count: 1,237 (no change)
  • Package size: 311 MB (no change)
  • Number of ts-expect-error directives: 420 ⬇️ 0.48% decrease vs. 33b60ba

@ndhoule ndhoule changed the base branch from main to nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default--refactor-types April 10, 2025 23:00
@ndhoule ndhoule force-pushed the nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default branch 4 times, most recently from fa80263 to 5f44426 Compare April 11, 2025 22:13
@ndhoule ndhoule force-pushed the nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default--refactor-types branch from 9dc32fe to 24376c5 Compare April 16, 2025 21:04
Base automatically changed from nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default--refactor-types to main April 16, 2025 21:30
This small change updates the `deploy` command to run the configured
`build` command before deployment.

Users who prefer the previous behavior can opt out by specifying
`--build=false` when running `netlify deploy`.
@ndhoule ndhoule force-pushed the nathanhoule/cpla-2545-change-ntl-deploy-to-build-by-default branch from 5f44426 to 6a799b0 Compare April 16, 2025 21:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant