test: fix flakey snapshot normalization logic #7203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhoule
approved these changes
Apr 14, 2025
| @@ -10,6 +10,12 @@ import { normalize } from './utils/snapshots.js' | |||
|
|
|||
| const content = 'Hello World!' | |||
|
|
|||
| // Normalize random ports | |||
| const normalizeSnapshot = (output, opts) => | |||
There was a problem hiding this comment.
👏
Love to see this vs. one big world-normalizing function.
This logic was normalizing integration test snapshots by replacing any sequence of five digits with `88888`. The intent is to handle some randomness in test output. It wasn't working some percentage of the time because randomly selected ports are sometimes _four_ digits. You can see an example in this failed run: https://github.com/netlify/cli/actions/runs/14434953424/job/40474516002?pr=7202#step:10:1143. While I was at it, I made it less much less generic and moved it into the only test suite that relies on it.
serhalp
force-pushed
the
serhalp/cpla-2573-fix-flaky-integration-tests-remove-ci-automatic-test-suite-2
branch
from
868d36d to
10c10ba
Compare
serhalp
deleted the
serhalp/cpla-2573-fix-flaky-integration-tests-remove-ci-automatic-test-suite-2
branch
serhalp
added a commit
that referenced
this pull request
Apr 15, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This logic was normalizing integration test snapshots by replacing any sequence of five digits with
88888. The intent is to handle some randomness in test output.It wasn't working some percentage of the time because randomly selected ports are sometimes four digits. You can see an example in this failed run: https://github.com/netlify/cli/actions/runs/14434953424/job/40474516002?pr=7202#step:10:1143.
While I was at it, I made it less much less generic and moved it into the only test suite that relies on it.