Skip to content

fix: fix for node 24 and add to test matrix #7213

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

serhalp
Copy link
Member

@serhalp serhalp commented Apr 15, 2025

Summary

node.js 24 was released and moved to "Current" status yesterday, May 6 2025: https://nodejs.org/en/blog/release/v24.0.0.

This bumps verdaccio and jsonwebtoken to fix a fatal error on node 24 coming from this transitive dependency: auth0/node-jwa#52.

While I was here, I did a bit of cleanup: for everything that isn't actually running vitest (prettier, etc.), just use the latest node.js LTS and always use the same alias (latest) for consistency.

CPLA-2660

To do

  • right before merging, delete old/renamed required checks and mark new/renamed checks as required

Copy link

github-actions bot commented Apr 15, 2025

📊 Benchmark results

Comparing with a017181

  • Dependency count: 1,148 ⬇️ 0.17% decrease vs. a017181
  • Package size: 280 MB ⬇️ 0.06% decrease vs. a017181
  • Number of ts-expect-error directives: 390 (no change)

@serhalp serhalp force-pushed the ci/test-node-24 branch 2 times, most recently from c502d6b to b6f44c2 Compare April 16, 2025 15:55
serhalp added 2 commits May 7, 2025 08:45
For everything that isn't actually running vitest, just use the latest LTS and always use
the same alias
@serhalp serhalp force-pushed the ci/test-node-24 branch from a834ee7 to faeb04d Compare May 7, 2025 12:47
This fixes a fatal error on the just-released node 24 coming from this transitive
dependency: auth0/node-jwa#52.
@serhalp serhalp changed the title ci: add node 24 to test matrices fix: fix for node 24 and add to test matrix May 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant