feat: fetch secrets from OneGraph as-needed #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix eslint and prettier
Expands on the GraphQL query for the service auths
dwwoelfel
changed the title
ascorbic
reviewed
Aug 3, 2021
|
|
||
| const formatSecrets = (result) => { | ||
| const services = | ||
| result.data && result.data.me && result.data.me.serviceMetadata && result.data.me.serviceMetadata.loggedInServices |
There was a problem hiding this comment.
I think optional chaining is what I miss most when not transpiling 😁
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches secrets on each usage of
withSecretsusing theONEGRAPH_AUTHLIFY_TOKEN. This works around the problem of needing to redeploy to update the secrets