Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: migrate to TypeScript #150

Merged
merged 12 commits into from
Oct 26, 2021
Merged

feat: migrate to TypeScript #150

merged 12 commits into from
Oct 26, 2021

Conversation

netlify-team-account-1
Copy link
Contributor

This PR migrates @netlify/functions to TypeScript.

Please review commit-by-commit.

@netlify-team-account-1 netlify-team-account-1 added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 25, 2021
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! Do you mind releasing a RC version and compare the file list, just to ensure we're not adding unnecessary fluff to the package?

package.json Outdated Show resolved Hide resolved
src/function/context.ts Show resolved Hide resolved
src/function/handler.ts Show resolved Hide resolved
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
// "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */

/* Language and Environment */
"target": "es5" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a note to update this to es6 when we update our minimum version.

@eduardoboucas eduardoboucas changed the title feat: migrate to typescript feat: migrate to TypeScript Oct 26, 2021
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kodiakhq kodiakhq bot merged commit d79ed42 into main Oct 26, 2021
@kodiakhq kodiakhq bot deleted the use-typescript branch October 26, 2021 14:34
@netlify-team-account-1
Copy link
Contributor Author

I checked the file list locally, everything seemed fine :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants