Skip to content

fix: add missing SRV dnsRecord properties #371

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robotblake
Copy link

SRV records contain a weight property and a port property. These properties are present in the dnsRecordCreate definition but not in the dnsRecord definition even though they are returned by the API.

@robotblake robotblake requested review from a team as code owners January 31, 2022 22:24
@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for open-api ready!

🔨 Explore the source changes: 5c2575e

🔍 Inspect the deploy log: https://app.netlify.com/sites/open-api/deploys/61f8652e16803c0008f3e564

😎 Browse the preview: https://deploy-preview-371--open-api.netlify.app

SRV records contain a `weight` property and a `port` property. These
properties are present in the `dnsRecordCreate` definition but not in
the `dnsRecord` definition even though they are returned by the API.
@robotblake robotblake changed the title Add missing SRV dnsRecord properties fix: add missing SRV dnsRecord properties Jan 31, 2022
@rstavchansky rstavchansky added the type: chore work needed to keep the product and development running smoothly label Feb 1, 2022
@kitop
Copy link
Contributor

kitop commented Sep 26, 2022

@robotblake mind rebasing this PR to fix conflicts?

@rstavchansky rstavchansky removed the request for review from a team February 2, 2023 14:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants