[feature] allow user custom max depth #155
Conversation
|
@UrielCh or we can deprecate the |
| @@ -103,7 +107,7 @@ public JSONParserBase(int permissiveMode) { | |||
| this.useHiPrecisionFloat = (permissiveMode & JSONParser.USE_HI_PRECISION_FLOAT) > 0; | |||
| this.checkTaillingData = (permissiveMode & (JSONParser.ACCEPT_TAILLING_DATA | |||
| | JSONParser.ACCEPT_TAILLING_SPACE)) != (JSONParser.ACCEPT_TAILLING_DATA | |||
There was a problem hiding this comment.
my screen is not large enough to read this line ...
may I get a human translation for this change?
There was a problem hiding this comment.
@UrielCh It's a style miss change. I will revert it.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| public class ParserOptions { |
There was a problem hiding this comment.
adding a flag to remove the limit can be enough?
adding and extra ParserOptions only for that, is... overkill ?
and this PR looks not to use maxDepth.
There was a problem hiding this comment.
@UrielCh Yes, as I said before, it's only a draft about external API changes.
|
@UrielCh We may not anticipate new requirements in the future, and it may be better to add an optional maximum value. What if the users reach the 1000 limit? We will have many flags that are difficult to maintain. We may add other flags as boolean variables in ParserOptions, flags or Options? |
|
Objects with a depth higher than 400 are not man-made and can be 1000 or 2000 level depth. For users using super-depth JSON objects, just drop the limit with a flag. Are you agree with this point? @Shoothzj Json-smart is in a stable state and should not introduce big changes. Or, if you have some bigger plan for the project, suggest a new roadmap that will use this extra option parameter. |
|
@UrielCh In consideration of stability, I agree to add a flag to remove this restriction. However, I believe that it's more common in Java to use struct configurations rather than flags. We could plan to implement this in future versions. |
|
I did not use configuration in json-smart for ... allmost 15 years, so adding a configuration for a single parameter, when a simple flag to disable the new limitation will do the job... no... |
|
PR commented. |
This pr currently is a draft. Only has public api, but still missing implementation and tests.