Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#73] Avoid String creation using system default charset #74

Merged
merged 1 commit into from
Apr 24, 2021
Merged

[#73] Avoid String creation using system default charset #74

merged 1 commit into from
Apr 24, 2021

Conversation

dpeger
Copy link
Contributor

@dpeger dpeger commented Apr 23, 2021

Used StandardCharsets.UTF_8 to create String in JSONParserByteArray to avoid dependency on system's default charset and added additional emoji test.

Fixes #73

Used `StandardCharsets.UTF_8` to create `String` in `JSONParserByteArray` to avoid dependency on system's default charset and added additional emoji test.

Fixes #73
Copy link
Contributor

@UrielCh UrielCh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@UrielCh UrielCh merged commit 9f6bb80 into netplex:master Apr 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode characters are not correctly parsed from byte[] if default charset is not UTF-8
2 participants