-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Release/2.0.0 - Composer 2 Compatibility #36
Conversation
- Set package version number to 2.0.0 - Update Plugin class implementing missing PluginInterface methods - Fix RemoteFilesystem constructor missing Config object - Track dependencies in git (composer.lock)
Looks like most of the PrettyCI errors are coming from exisiting source, i do not think they should delay the merge of this PR. |
For those looking to use these changes prior to this PR being merged do the following: Bump the require constraints where this package is used
Add the forked repository as a project repository
Update the package
|
We do not provide a composer.lock file as part of this repository, because this is not a standalone application. Please remove it from your PR. |
Hi @JParkinson1991 , thanks for your PR - please review my comments. |
And please also consider updating the README. |
@CybotTM i have removed Around adding version to |
What's blocking the merge/release of this? |
Hi @JParkinson1991 ,
Nothing, except the two tiny code formatting issues. Thank you for your effort. |
I wonder if it's worth forgetting about PrettyCI for now, given it seems to be abandoned? https://prettyci.com/goodbye Given the pressing need to have something out there composer 2 compatible do you release now and look to implement code standard enforcement/validation etc (possibly(using github actions) as part of a subsequent release? |
Hey @JParkinson1991 thanks for the work! @CybotTM would a new tag be possible for this work to reach the public :]? |
The following PR will make this package compatibile with Composer version 2.
src/Netresearch/Composer/Patches/Downloader/Composer.php
A major version bump is required here, due to the changes in
src/Netresearch/Composer/Patches/Downloader/Composer.php
as the package can no longer be compatibile with both composer 1 and 2 simultaneously.Consumers of this package can still require either version 1 or 2 as no pulic interfaces have changes.
For those wanting to use these changes now following instructions here: #36 (comment)