-
-
Notifications
You must be signed in to change notification settings - Fork 87
Session: added getFlashSection() #5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
public function getFlashSection($section) | ||
{ | ||
if (!$this->flashId) { | ||
$this->flashId = Nette\Utils\Random::generate(4) ?: '1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random::generate()
can fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Not sure why, but I don't like this. It's completely out of Session's scope. Also this is only a nette\application thing. Not sure it should be hardcoded into Session this way. |
This whole code should be object dependent on Session |
I have two implementations. This is one and the second one uses new class |
@dg Sorry I had in mind Tab and after searching just found out you changed the name back from Tab to Flash. nette/application#4 (comment) Where is the second one? |
The second one is only in my local branch. „Tab“ idea was completely wrong. I realized that the important is that it exists only during the redirect. |
Instead of explaining further I have created two pulls it should be clear from them what I meant. NOTE: Separating the session namespace from id is great idea the class just extends on that. |
287cae9
to
f55bed2
Compare
0bb4336
to
96b498c
Compare
No description provided.