Deprecate validateAndCollect
on JsonSchema
#1063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
validateAndCollect
in favor of explicitly callingloadCollectors
.This also deprecates the related
loadCollectors
configuration inSchemaValidatorsConfig
.This makes the
CollectorContext.loadCollectors()
method public to be explicitly called instead of relying on theSchemaValidatorsConfig
.Proper usage of the
validateAndCollect
method is confusing. It relies on a configuration set inSchemaValidatorsConfig
that is configured on a per schema basis. It immediately runsloadCollectors
if set totrue
and will never be able to runloadCollectors
if set tofalse
as the method is notpublic
.The documentation has been updated to reflect the replacement, which is to explicitly create the
CollectorContext
to be shared and set for each execution. FinallyloadCollectors
can be called a the end if needed.