Fixed validation for path parameters and query parameters #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following schema can work properly now - minimum - maximum - enum - pattern - maxItems - minItems
jiachen1120
changed the title
DSchrupert
reviewed
Jan 21, 2019
DSchrupert
reviewed
Jan 21, 2019
…LooseContainsInEnum and add comments to it, in addition, typeLoose check is been taken out from the method. - Reconstruct the isNumber check, now all the type check will be done by typeValidator, and minimumValidator and maximumValidator will reuse the isNumber() method provided by typeValidator. - Add typeLoose config into JsonSchemaTest and adding test cases in enum, minimum and maximum.
DSchrupert
approved these changes
Jan 22, 2019
|
@stevehu This is a dependency to the linked PR |
stevehu
approved these changes
Feb 4, 2019
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NicholasAzar @stevehu Since the RequestValidator is built on json-schema-validator. There is another PR related to this issue can be found in networknt/light-rest-4j repo. These changes in different repo contributions to the same issue.
RFC which specifies the details of fix can be found here: https://github.com/networknt/light-rfcs/blob/master/light-rest-4j/0001-openapi-validator-bug-fix.md