Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix custom error message for union type #1138

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

justin-tay
Copy link
Contributor

Closes #1137

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.09%. Comparing base (48ca3c2) to head (e596c08).
Report is 73 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1138      +/-   ##
============================================
- Coverage     78.90%   78.09%   -0.81%     
- Complexity     1965     2058      +93     
============================================
  Files           172      201      +29     
  Lines          6352     6849     +497     
  Branches       1255     1251       -4     
============================================
+ Hits           5012     5349     +337     
- Misses          867     1033     +166     
+ Partials        473      467       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit d9a7219 into networknt:master Dec 7, 2024
4 checks passed
@justin-tay justin-tay deleted the gh1137 branch January 27, 2025 09:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when I set type:["string",null],this custom errorMessage is invalid
3 participants