Resolve sub schema node only if really needed #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a JsonNode that contains a json schema and was supposed to be validated previously lead to a call to the url - but the url was possibly not yet correctly defined because the schema was not validated... so we need to do the id-based fetching only if actually needed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JsonSchemaFactory.getSchema is called with anything else than a URL, a specified ID property used to lead to the URI being resolved even if it was not necessary (because there was no ref that cannot be satisfied with the current schema). If the validation code is called to verify a Schema before it is accepted as the "official" schema for a given URI, it will fail because the resolved URI either does not exist yet or contains an older version. Thus I changed the implementation to resolve the sub schema node lazily.